Updates for persistent-2.5 and base-4.9#141
Updates for persistent-2.5 and base-4.9#141paul-rouse wants to merge 3 commits intoprowdsponsor:masterfrom
Conversation
|
So... will this be getting released soon? |
aws 0.14.0 is incompatible with http-conduit 2.2.0 aristidb/aws#206 esqueleto 2.4.3 is incompatible with persistent 2.5 prowdsponsor/esqueleto#137 prowdsponsor/esqueleto#141 prowdsponsor/esqueleto#139 Solver needs these hints when building git-annex with +S3 and +Webapp.
|
Keep in mind the people that prompted the changes in Persistent 2.5 already have a variant of Esqueleto updated to work with them: https://github.com/pseudonom/esqueleto/tree/split-db If you don't mind I'll put a PR of @pseudonom's changes in and ping the owner. |
|
As @paul-rouse said above
@pseudonom's changes do not allow This current PR seems to be the most appropriate one but it isn't getting merged? |
Ah yeah, that's an ache and a good point. |
|
The thing I like about my PR is that it annotates |
|
@pseudonom that was originally why I wanted your version. If you could reconcile the benefits of both, even with CPP, that would be great. |
|
Of course this PR uses CPP too, in just one file. It would be great if we can get the best of both worlds - I didn't attempt to make use of the new read-only functionality. Give me a shout if I can help, for example with testing. |
|
I suggest we close this in favour of #144 |
4 participants
I've built this and run the tests (sqlite only) with lts-6.2, lts-6.2 plus forced persistent*-2.5.X, and nightly-2016-06-08 to bring GHC 8 into the mix.
I included a major version bump because of the type constraint on
deleteKeychanging.Something has changed in the way
persistentexportscount, so I had to hide it explicitly, but I didn't get to the bottom of why.Hope it helps!